linux-kernel - RE: [PATCH] LP3971 PMIC regulator driver (updated and combined version)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <003901c9d874$77e2ad80$67a80880$%szyprowski@samsung.com>
Date:	Tue, 19 May 2009 13:25:03 +0200
From:	Marek Szyprowski <m.szyprowski@...sung.com>
To:	'Liam Girdwood' <lrg@...mlogic.co.uk>
Cc:	linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.arm.linux.org.uk, kyungmin.park@...sung.com,
	'Mark Brown' <broonie@...nsource.wolfsonmicro.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>
Subject: RE: [PATCH] LP3971 PMIC regulator driver (updated and combined version)

Hello,

On Tuesday, May 19, 2009 12:47 PM Liam Girdwood wrote:

> On Tue, 2009-05-19 at 10:58 +0100, Mark Brown wrote:
> > On Tue, May 19, 2009 at 07:33:55AM +0200, Marek Szyprowski wrote:
> > > This patch adds regulator drivers for National Semiconductors
> LP3971 PMIC.
> > > This LP3971 PMIC controller has 3 DC/DC voltage converters and 5
> low
> > > drop-out
> > > (LDO) regulators. LP3971 PMIC controller uses I2C interface.
> >
> > > Reviewed-by: Kyungmin Park <kyungmin.park@...sung.com>
> > > Signed-off-by: Marek Szyprowski <m.szyprowski@...sung.com>
> >
> > > +static int lp3971_dcdc_list_voltage(struct regulator_dev *dev,
> unsigned
> > > index)
> >
> > I'm OK with this but it looks like your MUA has mangled the patch by
> > word wrapping so Liam may not be able to apply it.  There's some
> hints
> > on configuring various mail clients in Documentation/email-
> clients.txt
> > which might be helpful.
> >
> 
> I've now applied the patch after it was mangled by outlook.

Thanks for your patience.

> I have also fixed the following build error :-
> `lp3971_i2c_remove' referenced in section `.data' of drivers/built-
> in.o: defined in discarded section `.devexit.text' of drivers/built-
> in.o
> [...]
> Best to pull for-next to get this fix.

Thanks for your fix!

Best regards
--
Marek Szyprowski
Samsung Poland R&D Center


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/