linux-kernel - Re: [RFC] mod_timer() helper functions?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090520081443.GA8684@one.firstfloor.org>
Date:	Wed, 20 May 2009 10:14:43 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Chris Peterson <cpeterso@...terso.com>
Cc:	Andi Kleen <andi@...stfloor.org>, linux-kernel@...r.kernel.org,
	tglx@...utronix.de
Subject: Re: [RFC] mod_timer() helper functions?

> /**
>  * timer_settime_msecs - modify a timer's timeout
>  * @timer: the timer to be modified
>  * @msecs: minimum time in milliseconds to sleep for
>  */
> int timer_settime_msecs(struct timer_list *timer, int msecs)

At least this function needs something that indicates it is very approximate
(upto 900% error for 1ms with HZ=100)
The old open coded pattern showed this. 

Or perhaps better drop the msecs version and just keep the seconds version.

People who want msecs accuracy likely should use hrtimers anyways.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/