linux-kernel - Re: [RFC] mod_timer() helper functions?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a24804730905200011l202733abh89f5d4feaf69610e@mail.gmail.com>
Date:	Wed, 20 May 2009 00:11:37 -0700
From:	Chris Peterson <cpeterso@...terso.com>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	linux-kernel@...r.kernel.org, tglx@...utronix.de
Subject: Re: [RFC] mod_timer() helper functions?

How about something like these helper functions?

The function names "timer_settime_msecs()" and "timer_settime_secs()"
are not fantastic, but they are inspired by the precedent set by the
POSIX Realtime function timer_settime().


/**
 * timer_settime_msecs - modify a timer's timeout
 * @timer: the timer to be modified
 * @msecs: minimum time in milliseconds to sleep for
 */
int timer_settime_msecs(struct timer_list *timer, int msecs)
{
	unsigned long expires = jiffies + msecs_to_jiffies(msecs);

	/* TODO? round_jiffies() if msecs parameter is large, say >= ~5000? */
        /* If people don't mind if timer_settime_msecs() rounds to
whole seconds, then timer_settime_secs() might be unnecessary. */

	return mod_timer(timer, expires);
}


/**
 * timer_settime_secs - modify a timer's timeout
 * @timer: the timer to be modified
 * @secs: approximate time in seconds to sleep for
 */
int timer_settime_secs(struct timer_list *timer, time_t secs)
{
	unsigned long expires = jiffies + (secs * HZ);

	/* If the caller doesn't mind waiting multiple seconds, then
	 * feel free to round up to whole seconds (to reduce wakeups).
	 */
	if (secs >= 2)
		expires = round_jiffies_up(expires);

	return mod_timer(timer, expires);
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/