linux-kernel - Re: [PATCH] crypto: hifn_795x - fix _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090520145623.GA4147@ioremap.net>
Date:	Wed, 20 May 2009 18:56:23 +0400
From:	Evgeniy Polyakov <zbr@...emap.net>
To:	Mike Frysinger <vapier@...too.org>
Cc:	linux-kernel@...r.kernel.org, Patrick McHardy <kaber@...sh.net>,
	Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [PATCH] crypto: hifn_795x - fix __dev{init,exit} markings

Hi Mike.

On Mon, May 18, 2009 at 03:51:50AM -0400, Mike Frysinger (vapier@...too.org) wrote:
> The remove member of the pci_driver hifn_pci_driver uses __devexit_p(),
> so the remove function itself should be marked with __devexit.  And where
> there be __devexit on the remove, so is there __devinit on the probe.
> 
> Similarly, the module_init/module_exit functions should be declared with
> plain __init/__exit markings, not the hotplug __dev{init,exit} ones.
> 
> Signed-off-by: Mike Frysinger <vapier@...too.org>
> CC: Evgeniy Polyakov <zbr@...emap.net>
> CC: Patrick McHardy <kaber@...sh.net>

Looks good, thank you Mike.
Ack. Herbert, please apply.

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/