linux-kernel - Re: [PATCH] crypto: hifn_795x - fix _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090527051635.GD7474@gondor.apana.org.au>
Date:	Wed, 27 May 2009 15:16:36 +1000
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Evgeniy Polyakov <zbr@...emap.net>
Cc:	Mike Frysinger <vapier@...too.org>, linux-kernel@...r.kernel.org,
	Patrick McHardy <kaber@...sh.net>
Subject: Re: [PATCH] crypto: hifn_795x - fix __dev{init,exit} markings

On Wed, May 20, 2009 at 06:56:23PM +0400, Evgeniy Polyakov wrote:
> Hi Mike.
> 
> On Mon, May 18, 2009 at 03:51:50AM -0400, Mike Frysinger (vapier@...too.org) wrote:
> > The remove member of the pci_driver hifn_pci_driver uses __devexit_p(),
> > so the remove function itself should be marked with __devexit.  And where
> > there be __devexit on the remove, so is there __devinit on the probe.
> > 
> > Similarly, the module_init/module_exit functions should be declared with
> > plain __init/__exit markings, not the hotplug __dev{init,exit} ones.
> > 
> > Signed-off-by: Mike Frysinger <vapier@...too.org>
> > CC: Evgeniy Polyakov <zbr@...emap.net>
> > CC: Patrick McHardy <kaber@...sh.net>
> 
> Looks good, thank you Mike.
> Ack. Herbert, please apply.

Applied to cryptodev.  Thanks a lot!
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/