linux-kernel - Re: [PATCH version 2] [SQUASHME] "FC Pass Thru support" fixed for block/for-2.6.31 tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 20 May 2009 20:03:09 +0300
From:	Boaz Harrosh <bharrosh@...asas.com>
To:	James Bottomley <James.Bottomley@...senPartnership.com>
CC:	Stephen Rothwell <sfr@...b.auug.org.au>, Tejun Heo <tj@...nel.org>,
	James Smart <James.Smart@...lex.Com>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	FUJITA Tomonori <tomof@....org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Jens Axboe <Jens.Axboe@...cle.com>
Subject: Re: [PATCH version 2] [SQUASHME] "FC Pass Thru support" fixed for
 block/for-2.6.31 tree

On 05/20/2009 07:59 PM, Boaz Harrosh wrote:
> On 05/20/2009 07:43 PM, James Bottomley wrote:
>> If you actually just ask scsi-post-merge-2.6 where this line is, it will
>> tell you:
>>
>> static void blk_finish_request(struct request *req, int error)
>> {
>>         BUG_ON(blk_queued_rq(req));
>> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>>
>>         if (blk_rq_tagged(req))
>>                 blk_queue_end_tag(req->q, req);
>>
>> James
>>
>>
> 
> This is a new BUG_ON from:
>     block: implement and enforce request peek/start/fetch
> 
> It looks like there is one more sight of the old usage that
> was not converted.
> 
> Tejun?
>  

The patch has a comment about that:
    * disallowing completion of queued (not started) requests

Do you have a stack trace?

Boaz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/