linux-kernel - Re: [PATCH] include KERN_* constant in printk calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4A151A40.1020901@bfs.de>
Date:	Thu, 21 May 2009 11:09:20 +0200
From:	walter harms <wharms@....de>
To:	michael@...erman.id.au
Cc:	Chris Sanford <crsanford@...il.com>,
	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
	peterz@...radead.org
Subject: Re: [PATCH] include KERN_* constant in printk calls



Michael Ellerman schrieb:
> On Wed, 2009-05-20 at 19:46 -0700, Chris Sanford wrote:
>> Here is the updated patch for sched.c. It replaces all the printk calls with their
>> corresponding pr_* call. The five KERN_DEBUG calls have been changed to
>> pr_info.
> 
> Switching from KERN_DEBUG to KERN_INFO means the messages will now
> appear for most people, whereas previously they didn't. I'm not sure
> that's a great idea.
> 
> If you really want to convert them, then I think we need a macro for
> KERN_DEBUG but not conditionally compiled like pr_debug.
> 
> I sent a patch for that once, but I don't think anyone liked it, and
> I've lost it now :D
> 

beeing mainly a user theses days i would like to comment ...

It is fine if debug statements are disabled within NO_DEBUG mode.
As user i find them annoying because i do not care.
KERN_INFO is ok and if people complain they need more info someone
can always change from DEBUG to INFO.
putting to much info into syslog simply drowns important informations.
so keep it as pr_debug().

just my 2 cents,
 wh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/