linux-kernel - Re: [PATCH] include KERN_* constant in printk calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1242882592.4784.44.camel@concordia>
Date:	Thu, 21 May 2009 15:09:52 +1000
From:	Michael Ellerman <michael@...erman.id.au>
To:	Chris Sanford <crsanford@...il.com>
Cc:	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
	peterz@...radead.org
Subject: Re: [PATCH] include KERN_* constant in printk calls

On Wed, 2009-05-20 at 19:46 -0700, Chris Sanford wrote:
> Here is the updated patch for sched.c. It replaces all the printk calls with their
> corresponding pr_* call. The five KERN_DEBUG calls have been changed to
> pr_info.

Switching from KERN_DEBUG to KERN_INFO means the messages will now
appear for most people, whereas previously they didn't. I'm not sure
that's a great idea.

If you really want to convert them, then I think we need a macro for
KERN_DEBUG but not conditionally compiled like pr_debug.

I sent a patch for that once, but I don't think anyone liked it, and
I've lost it now :D

cheers

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)