linux-kernel - Re: [PATCH resend4 3/3] itimers: simplify arm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0905221629080.3570@localhost.localdomain>
Date:	Fri, 22 May 2009 16:30:09 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Stanislaw Gruszka <sgruszka@...hat.com>
cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Oleg Nesterov <oleg@...hat.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH resend4 3/3] itimers: simplify arm_timer() code a bit

On Fri, 22 May 2009, Stanislaw Gruszka wrote:
>  			case CPUCLOCK_PROF:
> -				if (cputime_eq(p->cputime_expires.prof_exp,
> -					       cputime_zero) ||
> -				    cputime_gt(p->cputime_expires.prof_exp,
> -					       nt->expires.cpu))
> -					p->cputime_expires.prof_exp =
> -						nt->expires.cpu;
> +				if (expires_le(p->cputime_expires.prof_exp,
> +					       exp->cpu))
> +					break;

  Why the reverse logic and the extra break ?

> +				p->cputime_expires.prof_exp = exp->cpu;
>  				break;

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/