linux-kernel - Re: [PATCH 3/3] drivers/ide/ide-core: Unsplit constant strings for pr_<level> and dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 24 May 2009 09:46:36 -0700
From:	Joe Perches <joe@...ches.com>
To:	Sergei Shtylyov <sshtylyov@...mvista.com>
Cc:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>,
	Borislav Petkov <petkovbb@...il.com>,
	Tejun Heo <tj@...nel.org>, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] drivers/ide/ide-core: Unsplit constant strings for
 pr_<level> and dev_<level>

On Sun, 2009-05-24 at 16:12 +0400, Sergei Shtylyov wrote:
> > -		dev_err(&drive->gendev, "%s: packet size (0x%02x) is not 12 "
> > -			"bytes\n", s, packet_size);
> > +		dev_err(&drive->gendev,
> > +			"%s: packet size (0x%02x) is not 12 bytes\n",
>    When the message is broken by the format specifier, turning it into 
> one liner can hardly help seraching...

grep "is not 12 bytes"

>    Oh noes, the indentation...

trade-offs...

> > +	"(IO,CoD != (0,1) while issuing a packet command, retrying\n");
>    Sigh...

You seem to sigh a lot.  ;)

> > +	"(IO,CoD != (0,1) while issuing a packet command, ignoring\n");
>    Sigh...
> > +	"Strange, packet command initiated yet DRQ isn't asserted\n");
>    Sigh...
> > +		"(IO,CoD) != (0,1) while issuing a packet command\n");
>    Sigh...
> > +		"unexpected interrupt, status=0x%02x, count=%ld\n",
>    Hardly won anything...
> > + "%s side 80-wire cable detection failed, limiting max speed to UDMA33\n",
>     Will you really use the full message to serch here?
> > +		 "probing with STATUS(0x%02x) instead of ALTSTATUS(0x%02x)\n",
>    Same comment about the line broken by the format specifiers. This 
> wins absolutely nothing.

grep "STATUS.*ALTSTATUS"

> > +		"no response (status = 0x%02x), resetting drive\n",
>    And again...

grep "response.*resetting"

> > +			"%s Multimode Write multcount is not set\n",
>    Sigh...
> > +			"%s Multimode Read failure multcount is not set\n",
>    Sigh...
> > +		"%s %s: device not capable of full native PCI mode\n",
>    Sigh...
> > +		"%s %s: rewrite of PROGIF failed, wanted 0x%04x, got 0x%04x\n",
> > +		"%s %s: I/O baseregs (BIOS) are reported as MEM for port %d!\n",
>    Sigh...
> > +		"%s %s: not 100%% native mode: will probe irqs later\n",
>    Sigh...

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/