linux-kernel - Re: [PATCH 3/3] drivers/ide/ide-core: Unsplit constant strings for pr_<level> and dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 24 May 2009 22:00:23 +0400
From:	Sergei Shtylyov <sshtylyov@...mvista.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>,
	Borislav Petkov <petkovbb@...il.com>,
	Tejun Heo <tj@...nel.org>, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] drivers/ide/ide-core: Unsplit constant strings for
 pr_<level> and dev_<level>

Hello.

Joe Perches wrote:

>>>-		dev_err(&drive->gendev, "%s: packet size (0x%02x) is not 12 "
>>>-			"bytes\n", s, packet_size);
>>>+		dev_err(&drive->gendev,
>>>+			"%s: packet size (0x%02x) is not 12 bytes\n",

>>   When the message is broken by the format specifier, turning it into 
>>one liner can hardly help seraching...

> grep "is not 12 bytes"

    Yes, carrying "is not 12 " to that would have made sense.

>>   Oh noes, the indentation...

> trade-offs...

>>>+	"(IO,CoD != (0,1) while issuing a packet command, retrying\n");

>>   Sigh...

> You seem to sigh a lot.  ;)

    I'm not sure you'll like "ugh" better.

>>>+		"unexpected interrupt, status=0x%02x, count=%ld\n",

>>   Hardly won anything...
>>
>>>+ "%s side 80-wire cable detection failed, limiting max speed to UDMA33\n",
>>
>>    Will you really use the full message to serch here?
>>
>>>+		 "probing with STATUS(0x%02x) instead of ALTSTATUS(0x%02x)\n",
>>
>>   Same comment about the line broken by the format specifiers. This 
>>wins absolutely nothing.

> grep "STATUS.*ALTSTATUS"

    Hm, I didn't think about wildcards. Yet I find search for "probing with 
STATUS" more probable.

>>>+		"no response (status = 0x%02x), resetting drive\n",
>>
>>   And again...

> grep "response.*resetting"

    I'd grep for "no response (status =" in this case.

> cheers, Joe

MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/