linux-kernel - Re: [PATCH -tip] x86: kvm/paging_tmpl.h intialize the variable before using it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A1A2ADC.1090004@redhat.com>
Date:	Mon, 25 May 2009 08:21:32 +0300
From:	Avi Kivity <avi@...hat.com>
To:	Jaswinder Singh Rajput <jaswinder@...nel.org>
CC:	Ingo Molnar <mingo@...e.hu>, x86 maintainers <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -tip] x86: kvm/paging_tmpl.h intialize the variable before
 using it

Jaswinder Singh Rajput wrote:
>> It's a false alarm.  Isn't there a macro to shut up the warning?
>>
>>     
>
> In arch/x86/kvm/paging_tmpl.h sptep is initialize only in :
>
> for_each_shadow_entry(vcpu, addr, iterator) {
>
> If we skip this, then we end up with wild sptep and returning it.
>
> Do you still think it is a false alarm ?
>   

That loop always has at least one iteration.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/