linux-kernel - Re: [PATCH -tip] x86: kvm/paging_tmpl.h intialize the variable before using it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1243229852.3157.19.camel@localhost.localdomain>
Date:	Mon, 25 May 2009 11:07:32 +0530
From:	Jaswinder Singh Rajput <jaswinder@...nel.org>
To:	Avi Kivity <avi@...hat.com>
Cc:	Ingo Molnar <mingo@...e.hu>, x86 maintainers <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -tip] x86: kvm/paging_tmpl.h intialize the variable
 before using it

On Mon, 2009-05-25 at 08:21 +0300, Avi Kivity wrote:
> Jaswinder Singh Rajput wrote:
> >> It's a false alarm.  Isn't there a macro to shut up the warning?
> >>
> >>     
> >
> > In arch/x86/kvm/paging_tmpl.h sptep is initialize only in :
> >
> > for_each_shadow_entry(vcpu, addr, iterator) {
> >
> > If we skip this, then we end up with wild sptep and returning it.
> >
> > Do you still think it is a false alarm ?
> >   
> 
> That loop always has at least one iteration.
> 

hmm, In that case we should use a do-while flavor function so that the
compiler will also happy with it.

--
JSR

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/