linux-kernel - Re: linux-next: md tree build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090525061552.GH11363@kernel.dk>
Date:	Mon, 25 May 2009 08:15:52 +0200
From:	Jens Axboe <jens.axboe@...cle.com>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	Neil Brown <neilb@...e.de>, linux-next@...r.kernel.org,
	linux-kernel@...r.kernel.org, raz ben yehuda <raziebe@...il.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>
Subject: Re: linux-next: md tree build failure

On Mon, May 25 2009, Stephen Rothwell wrote:
> Hi Neil,
> 
> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> 
> drivers/md/raid0.c: In function 'create_strip_zones':
> drivers/md/raid0.c:243: error: 'struct request_queue' has no member named 'hardsect_size'
> 
> Caused by commit e1defc4ff0cf57aca6c5e3ff99fa503f5943c1f1 ("block: Do
> away with the notion of hardsect_size") from the block tree interacting
> with commit 131e4477401ae76a9cbe8539e4b7819e04cfba36 ("md: raid0: chunk
> size check in raid0_run") from the md tree.

Martin, this is starting to look like a disaster :-(

> 
> I applied the following patch.
> -- 
> Cheers,
> Stephen Rothwell                    sfr@...b.auug.org.au
> 
> diff --git a/drivers/md/raid0.c b/drivers/md/raid0.c
> index b8a0747..0bf275d 100644
> --- a/drivers/md/raid0.c
> +++ b/drivers/md/raid0.c
> @@ -240,7 +240,7 @@ static int create_strip_zones(mddev_t *mddev)
>  	 * now since we have the hard sector sizes, we can make sure
>  	 * chunk size is a multiple of that sector size
>  	 */
> -	if (mddev->chunk_size % mddev->queue->hardsect_size) {
> +	if (mddev->chunk_size % queue_logical_block_size(mddev->queue)) {
>  		printk(KERN_ERR "%s chunk_size of %d not valid\n",
>  		       mdname(mddev),
>  		       mddev->chunk_size);

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/