linux-kernel - Re: [PATCH 1/1] ptrace: wait_task_zombie: s/->parent/->real

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090526202336.E8B3AFC2BD@magilla.sf.frob.com>
Date:	Tue, 26 May 2009 13:23:36 -0700 (PDT)
From:	Roland McGrath <roland@...hat.com>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Christoph Hellwig <hch@...radead.org>,
	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] ptrace: wait_task_zombie: s/->parent/->real_parent/

> Change wait_task_zombie() to use ->real_parent instead of ->parent.

Acked-by: Roland McGrath <roland@...hat.com>

> We could even use current afaics, but ->real_parent is more clean.

Indeed, though the caller might not be ->real_parent, it will always be
one that shares ->signal with ->real_parent.  But I agree that using
->real_parent is the clean way.  Incidentally, as readability cleanup it
would make a lot of sense to move that block into a subroutine.


Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/