linux-kernel - Re: [PATCH -tip][SCSI] scsi: scsi_transport_iscsi.c initialize the variable before it get used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4A1C60E8.1070004@cs.wisc.edu>
Date:	Tue, 26 May 2009 16:36:40 -0500
From:	Mike Christie <michaelc@...wisc.edu>
To:	Jaswinder Singh Rajput <jaswinder@...nel.org>
CC:	James Bottomley <James.Bottomley@...senPartnership.com>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	Ingo Molnar <mingo@...e.hu>, x86 maintainers <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -tip][SCSI] scsi: scsi_transport_iscsi.c initialize the
 variable before it get used

Jaswinder Singh Rajput wrote:
> I am watching this problem from long time in -tip.
> 
> Subject: [PATCH] scsi: scsi_transport_iscsi.c initialize the variable before it get used
> 
> In some cases, err will be used uninitialized.
> 

As you guys already discussed it will not get used uninitialized.

> Also fixed compilation warning :
> 
>  CC      drivers/scsi/scsi_transport_iscsi.o
> drivers/scsi/scsi_transport_iscsi.c: In function ‘iscsi_add_session’:
> drivers/scsi/scsi_transport_iscsi.c:678: warning: ‘err’ may be used uninitialized in this function
> 

I did the attached patch to silence the compile warning. I goofed and 
forgot to send it before, because I had change my compiler and was not 
seeing the error message. I was planning on sending the attached with 
some other changes for the next feature window. I am going to fix up the 
patch to use UINT_MAX like James mentioned in the thread.

View attachment "0001-iscsi-class-quiet-iscsi_add_session-compilation-war.patch" of type "text/x-patch" (1222 bytes)