linux-kernel - Re: [PATCH] devres: WARN() and return, don't crash on device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1243376610.17847.12.camel@pasglop>
Date:	Wed, 27 May 2009 08:23:30 +1000
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org, greg@...ah.com,
	Kay Sievers <kay.sievers@...y.org>, Tejun Heo <tj@...nel.org>
Subject: Re: [PATCH] devres: WARN() and return, don't crash on device_del()
 of uninitialized device

On Tue, 2009-05-26 at 14:15 -0700, Andrew Morton wrote:
> 
> This could be coded a little more neatly as:
> 
>         /* Looks like an uninitialized device structure */
>         if (WARN_ON(dev->devres_head.next == NULL))
>                 return -ENODEV;

Oh I didn't know we could do that nowadays...

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/