linux-kernel - Re: Oops in usb-serial with keyspan adapter on current upstream

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1243376885.17847.15.camel@pasglop>
Date:	Wed, 27 May 2009 08:28:05 +1000
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	"Rafael J. Wysocki" <rjw@...k.pl>,
	Linux Kernel list <linux-kernel@...r.kernel.org>,
	linux-usb@...r.kernel.org
Subject: Re: Oops in usb-serial with keyspan adapter on current upstream

On Tue, 2009-05-26 at 10:06 -0400, Alan Stern wrote:
> On Tue, 26 May 2009, Benjamin Herrenschmidt wrote:
> 
> > Well, both our patches are bogus in the sense that they will leak
> > the stuff in the port structure.
> 
> That's not true at all.  Take a look at the destroy_serial() routine.

Right... hrm. This is an horrible mess, I can't wait to see that
refcount going wrong and things trying to double free or leaking the
structure.

Oh well, fix it the way your want, I don't care as long as it's fixed.
This driver is just plain horrible.

Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/