linux-kernel - Re: [PATCH 17/38] groups: move code to kernel/groups.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090526232511.GA23806@hallyn.com>
Date:	Tue, 26 May 2009 18:25:11 -0500
From:	"Serge E. Hallyn" <serge@...lyn.com>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	akpm@...ux-foundation.org, xemul@...allels.com,
	containers@...ts.linux-foundation.org,
	linux-kernel@...r.kernel.org, dave@...ux.vnet.ibm.com,
	mingo@...e.hu, torvalds@...ux-foundation.org
Subject: Re: [PATCH 17/38] groups: move code to kernel/groups.c

Quoting Alexey Dobriyan (adobriyan@...il.com):
> On Tue, May 26, 2009 at 09:48:19AM -0500, Serge E. Hallyn wrote:
> > Quoting Alexey Dobriyan (adobriyan@...il.com):
> > > Move supplementary groups implementation to kernel/groups.c .
> > > kernel/sys.c already accumulated quite a few random stuff.
> > > 
> > > Do strictly copy/paste + add required headers to compile.
> > > Compile-tested on many configs and archs.
> > > 
> > > Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>
> > 
> > Actually I needed the following change:
> 
> This is dealt by first patch:
> "[PATCH 01/38] cred: #include init.h in cred.h"
> which is in -mm already.
> 
> > --- a/kernel/groups.c
> > +++ b/kernel/groups.c
> > @@ -1,6 +1,7 @@
> >  /*
> >   * Supplementary group IDs
> >   */
> > +#include <linux/init.h>
> 
> Wrong, groups.c doesn't use __init at all.

Right you are.

thanks,
-serge
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/