linux-kernel - Re: [PATCH] firmware: Allocate firmware id dynamically

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1243405186.20399.8.camel@localhost.localdomain>
Date:	Wed, 27 May 2009 08:19:46 +0200
From:	Marcel Holtmann <holtmann@...ux.intel.com>
To:	Kay Sievers <kay.sievers@...y.org>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Zhu, Yi" <yi.zhu@...el.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	"linville@...driver.com" <linville@...driver.com>,
	Greg Kroah-Hartmann <greg@...ah.com>
Subject: Re: [PATCH] firmware: Allocate firmware id dynamically

Hi Samuel,

> > Since the firmware loader is not maintained by anyone, I'm sending this one to
> > you, for the next merge window:
> 
> It's part of the driver-core directory, and handled by Greg.
> 
> > The firmware loader has a statically allocated 30 bytes long string for the
> > firmware id (a.k.a. the firmware file name). There is no reason why we couldnt
> > allocate dynamically, and avoid having restrictions on the firmware names
> > lengths.
> 
> Looks good.

Acked-by: Marcel Holtmann <marcel@...tmann.org>

> > Please note that we have to keep the FIRMWARE_NAME_MAX definition around as
> > some drivers rely on it.
> 
> I think the 6 files should be converted, and FIRMWARE_NAME_MAX
> removed, otherwise people will keep copying that crap around.
> 
>   drivers/pcmcia/ds.c
>   drivers/usb/atm/ueagle-atm.c
>   drivers/net/wireless/libertas/if_usb.c
>   drivers/net/wireless/libertas/if_spi.c
>   drivers/media/dvb/dvb-usb/dvb-usb.h
>   drivers/media/common/tuners/tuner-xc2028.c

I do agree with Kay here that we should just go ahead and fix these.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/