linux-kernel - Re: [PATCH] firmware: Allocate firmware id dynamically

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090527115748.9ff0bad1.sfr@canb.auug.org.au>
Date:	Wed, 27 May 2009 11:57:48 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Kay Sievers <kay.sievers@...y.org>, sameo@...ux.intel.com,
	holtmann@...ux.intel.com, yi.zhu@...el.com,
	linux-kernel@...r.kernel.org, linville@...driver.com,
	greg@...ah.com
Subject: Re: [PATCH] firmware: Allocate firmware id dynamically

Hi all,

On Tue, 26 May 2009 13:23:51 -0700 Andrew Morton <akpm@...ux-foundation.org> wrote:
>
> > > Please note that we have to keep the FIRMWARE_NAME_MAX definition around as
> > > some drivers rely on it.
> > 
> > I think the 6 files should be converted, and FIRMWARE_NAME_MAX
> > removed, otherwise people will keep copying that crap around.
> > 
> >   drivers/pcmcia/ds.c
> >   drivers/usb/atm/ueagle-atm.c
> >   drivers/net/wireless/libertas/if_usb.c
> >   drivers/net/wireless/libertas/if_spi.c
> >   drivers/media/dvb/dvb-usb/dvb-usb.h
> >   drivers/media/common/tuners/tuner-xc2028.c
> 
> Yep.

$ git grep -l -w FIRMWARE_NAME_MAX next-20090526 
next-20090526:drivers/base/firmware_class.c
next-20090526:drivers/media/common/tuners/tuner-xc2028.c
next-20090526:drivers/media/dvb/dvb-usb/dvb-usb.h
next-20090526:drivers/net/wireless/libertas/if_spi.c
next-20090526:drivers/net/wireless/libertas/if_usb.c
next-20090526:drivers/net/wireless/p54/p54usb.c
next-20090526:drivers/pcmcia/ds.c
next-20090526:drivers/usb/atm/ueagle-atm.c
next-20090526:include/linux/firmware.h
next-20090526:samples/firmware_class/firmware_sample_firmware_class.c

Its already started ...

/me looks forward to more breakage in -next :-(
-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped