linux-kernel - Re: One question about perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090527144635.GA7300@elte.hu>
Date:	Wed, 27 May 2009 16:46:35 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Yong Wang <yong.y.wang@...ux.intel.com>
Cc:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	linux-kernel@...r.kernel.org
Subject: Re: One question about perf_counter on IA


* Yong Wang <yong.y.wang@...ux.intel.com> wrote:

> I noticed that the LVT error register is masked and then unmasked 
> during perf_counter initialization on IA in 
> arch/x86/kernel/cpu/perf_counter.c
> 
> void perf_counters_lapic_init(int nmi)
> {
> 	u32 apic_val;
> 
> 	if (!x86_pmu_initialized())
> 		return;
> 
> 	/*
> 	 * Enable the performance counter vector in the APIC LVT:
> 	 */
> 	apic_val = apic_read(APIC_LVTERR);
> 
> 	apic_write(APIC_LVTERR, apic_val | APIC_LVT_MASKED);
> 	if (nmi)
> 		apic_write(APIC_LVTPC, APIC_DM_NMI);
> 	else
> 		apic_write(APIC_LVTPC, LOCAL_PERF_VECTOR);
> 	apic_write(APIC_LVTERR, apic_val);
> }
> 
> Why is this needed? Is this documented somewhere in the spec? I 
> tried commenting out the masking and unmasking operations and I 
> did not any error interrupt generated.

i think a spurious error irq can be triggered due to APIC_DM_NMI 
having zero for the vector bit. If we switch between irq and nmi 
mode frequently then there could be racy situations.

Not that having an error irq would hurt much ...

Note, in the current code we essentially always use NMI mode, the 
cleanups just have not propagated through fully yet. Feel free to 
send a patch for this!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/