linux-kernel - Re: [PATCH 17/17] xen: disable MSI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090527211828.GA6166@elte.hu>
Date:	Wed, 27 May 2009 23:18:28 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Jeremy Fitzhardinge <jeremy@...p.org>,
	the arch/x86 maintainers <x86@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Xen-devel <xen-devel@...ts.xensource.com>,
	Greg KH <gregkh@...e.de>, Jens Axboe <jens.axboe@...cle.com>,
	Chris Wright <chrisw@...hat.com>, kurt.hackel@...cle.com,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ky Srinivasan <ksrinivasan@...ell.com>,
	Beulich <jbeulich@...ell.com>, Avi Kivity <avi@...hat.com>,
	Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com>
Subject: Re: [PATCH 17/17] xen: disable MSI


* Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> On Wed, 27 May 2009, Jeremy Fitzhardinge wrote:
> > 
> > [ Impact: prevent MSI subsystem from crashing ]
> 
> Grr.
> 
> I looked at several of these impact lines, and they were _all_ totally 
> misleading.
> 
> Please, guys. Stop with the F*CKING impact lines already. Add them 
> if they are obvious, but don't make them this idiotic "do an 
> impact line whether or not it makes sense".
> 
> I hate them. They are stupid. 90% of all the impact lines I see 
> are either (a) misleading or (b) totally inane and pointless.
> 
> In this case, we would have been a LOT BETTER OFF with having just 
> a better header line that said "xen: disable MSI to avoid crash" 
> or something like that. But no. THAT F*CKING IMPACT LINE 
> apparently meant that Jeremy just turned off his brain, and made 
> _both_ the header line and the Impact: line be non-descriptive.
> 
> Really. Stop it. Ingo, start saying "no" to people, at least for 
> impact lines that do not make sense. It adds _nothing_, and it 
> actually detracts from real content, because just the inanity of 
> them delutes the whole meaning of it.

hm, i have to concur. Too often it ends up splitting attention away 
from the title of the commit. I do reject (or fix up) bad impact 
lines - will stop doing them altogether if you think there's a net 
downside to them ...

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/