linux-kernel - Re: [PATCH 2/2 -tip] drm/i915: intel_lvds.c fix section mismatch warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200905281100.21386.jarod@redhat.com>
Date:	Thu, 28 May 2009 11:00:20 -0400
From:	Jarod Wilson <jarod@...hat.com>
To:	Jaswinder Singh Rajput <jaswinder@...nel.org>
Cc:	Ingo Molnar <mingo@...e.hu>, Eric Anholt <eric@...olt.net>,
	mjg@...hat.com, Sam Ravnborg <sam@...nborg.org>,
	x86 maintainers <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2 -tip] drm/i915: intel_lvds.c fix section mismatch warning

On Wednesday 20 May 2009 02:27:35 Jaswinder Singh Rajput wrote:
> 
> intel_no_lvds[] does not require __initdata as it is used only by :
> 
>   void intel_lvds_init(struct drm_device *dev)
> 
> fixes section mismatch warning:
> 
>   WARNING: drivers/gpu/drm/i915/i915.o(.text+0xf3c5): Section mismatch in reference from the function intel_lvds_init() to the variable .init.data:intel_no_lvds
>   The function intel_lvds_init() references
>   the variable __initdata intel_no_lvds.
>   This is often because intel_lvds_init lacks a __initdata

This would seem to suggest __initdata should be added to
intel_lvds_init, rather than removed from intel_no_lvds...

But I suppose either one would work. Apologies for not
catching the initial mismatch... :\

> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...il.com>
> ---
>  drivers/gpu/drm/i915/intel_lvds.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c
> index 439a865..5ffadf9 100644
> --- a/drivers/gpu/drm/i915/intel_lvds.c
> +++ b/drivers/gpu/drm/i915/intel_lvds.c
> @@ -391,7 +391,7 @@ static int __init intel_no_lvds_dmi_callback(const struct dmi_system_id *id)
>  }
>  
>  /* These systems claim to have LVDS, but really don't */
> -static const struct dmi_system_id __initdata intel_no_lvds[] = {
> +static const struct dmi_system_id intel_no_lvds[] = {
>  	{
>  		.callback = intel_no_lvds_dmi_callback,
>  		.ident = "Apple Mac Mini (Core series)",


-- 
Jarod Wilson
jarod@...hat.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/