linux-kernel - Re: [RFC PATCH 0/12 v2] ptrace: introduce task_struct->ptrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090529201856.1F451FC2BD@magilla.sf.frob.com>
Date:	Fri, 29 May 2009 13:18:56 -0700 (PDT)
From:	Roland McGrath <roland@...hat.com>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Christoph Hellwig <hch@...radead.org>, Ingo Molnar <mingo@...e.hu>,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 0/12 v2] ptrace: introduce task_struct->ptrace_cxt

> > 5/12 still needs a comment about its assumption that tracehook_init_task()
> > allocated the struct iff appropriate.
> 
> Not sure I understand... Where should I put this comment?

ptrace_init_task, to explain this line:

-	if (unlikely(ptrace)) {
+	if (unlikely(child->ptrace_ctx)) {

> OK, will redo and resend. Perhaps I should send this series to you
> privately? I don't like to flood lkml again, the changes are cosmetic.

:-) Whatever you like.  They will surely be posted at least twice more
before they get merged either way.  The idea that any actual useful patches
might pollute the purity of the lkml stream is amusing.  (Post them twice,
it will nudge up the signal-to-noise ratio. ;-)


Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/