linux-kernel - Re: [tip:x86/mce3] x86, mce: trivial clean up for mce_intel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4A204313.9090102@zytor.com>
Date:	Fri, 29 May 2009 13:18:27 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Andi Kleen <andi@...stfloor.org>
CC:	linux-kernel@...r.kernel.org, mingo@...hat.com,
	seto.hidetoshi@...fujitsu.com, tglx@...utronix.de,
	linux-tip-commits@...r.kernel.org, apw@...onical.com
Subject: Re: [tip:x86/mce3] x86, mce: trivial clean up for mce_intel_64.c

Andi Kleen wrote:
>> x86, mce: trivial clean up for mce_intel_64.c
>>
>> Fix for:
>>
>> WARNING: space prohibited between function name and open parenthesis '('
>> +       for_each_online_cpu (cpu) {
> 
> Sorry but that's just a bogus change. That's a loop and we always
> put spaces between the loop keyword and its condition.
> 
> Just because checkpatch.pl is too dumb to understand that is no
> reason to make the code worse like that.
> 

Look at EVERY OTHER for_each_online_cpu in the kernel.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/