linux-kernel - Re: [PATCH] ath5k: added initial RFKILL support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200905300033.12204.tobias.doerffel@gmail.com>
Date:	Sat, 30 May 2009 00:33:07 +0200
From:	Tobias Doerffel <tobias.doerffel@...il.com>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	Bob Copeland <me@...copeland.com>,
	Jiri Slaby <jirislaby@...il.com>, ath5k-devel@...ts.ath5k.org,
	mickflemm@...il.com, linux-wireless@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ath5k: added initial RFKILL support

Hi,

Am Dienstag, 26. Mai 2009 01:32:46 schrieb Johannes Berg:
> On Tue, 2009-05-26 at 01:24 +0200, Tobias Doerffel wrote:
> > +       err = rfkill_register(sc->rf_kill.rfkill);
> > +       if (err) {
> > +               sc->rf_kill.rfkill = NULL;
> > +               return -1;
> > +       }
>
> Missing rfkill_free, and why -EPERM?
Thanks for this remark. I fixed the code and will post an updated patch soon.

Any other comments on the patch? If not, any chance to get it merged into 
wireless-testing branch?

> Could you try to work against v11
> of my rfkill patch, or better even against the cfg80211 rfkill instead?
I didn't look at both of them yet. However I think we first should try to get 
current rfkill support into mainline as fast as possible. Improvements and 
adaptations to reworked rfkill framework can follow.

Regards,

Toby

Download attachment "signature.asc " of type "application/pgp-signature" (198 bytes)