lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4A21E816.4050203@redhat.com>
Date:	Sat, 30 May 2009 22:14:46 -0400
From:	Rik van Riel <riel@...hat.com>
To:	"Larry H." <research@...reption.com>
CC:	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	Alan Cox <alan@...rguk.ukuu.org.uk>, pageexec@...email.hu,
	Linus Torvalds <torvalds@...l.org>
Subject: Re: [PATCH] Use kzfree in mac80211 key handling to enforce data	sanitization

Larry H. wrote:
> [PATCH] Use kzfree in mac80211 key handling to enforce data sanitization
> 
> This patch replaces the kfree() calls within the mac80211 WEP RC4 key
> handling and ieee80211 management APIs with kzfree(), to enforce
> sanitization of the key buffer contents.
> 
> This prevents the keys from persisting on memory, potentially
> leaking to other kernel users after re-allocation of the memory by
> the LIFO allocators, or in coldboot attack scenarios. Information can be
> leaked as well due to use of uninitialized variables, or other bugs.
> 
> This patch doesn't affect fastpaths.

This seems to be essentially what Ingo proposed.

Clearing out a buffer that held a wifi key on free
makes sense, even for systems that are not in
paranoid mode.

> Signed-off-by: Larry Highsmith <research@...reption.com>

Acked-by: Rik van Riiel <riel@...hat.com>

-- 
All rights reversed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ