lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 31 May 2009 11:30:22 +1000 From: Herbert Xu <herbert@...dor.apana.org.au> To: Andrew Morton <akpm@...ux-foundation.org> Cc: Atsushi Nemoto <anemo@....ocn.ne.jp>, linux-mips@...ux-mips.org, ralf@...ux-mips.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] hwrng: Add TX4939 RNG driver On Fri, May 29, 2009 at 04:29:07PM -0700, Andrew Morton wrote: > > > +static u64 read_rng(void __iomem *base, unsigned int offset) > > +{ > > + /* Caller must disable interrupts */ > > + return ____raw_readq(base + offset); > > +} > > What is the reasoning behind the local_irq_disable() requirement? > > Because I'm wondering whether this is safe on SMP? Yes I'd like to see this fixed before adding this patch. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists