| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20090601101440.203c000a@lxorguk.ukuu.org.uk> Date: Mon, 1 Jun 2009 10:14:40 +0100 From: Alan Cox <alan@...rguk.ukuu.org.uk> To: Michael Buesch <mb@...sch.de> Cc: Andrew Morton <akpm@...ux-foundation.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: parport_pc: Fix subscription bugs On Mon, 1 Jun 2009 11:00:33 +0200 Michael Buesch <mb@...sch.de> wrote: > This patch fixes array subscription bugs in the parport_pc driver. > > drivers/parport/parport_pc.c: In function ‘parport_irq_probe’: > drivers/parport/parport_pc.c:1589: warning: array subscript is above array bounds > drivers/parport/parport_pc.c: In function ‘parport_pc_probe_port’: > drivers/parport/parport_pc.c:1579: warning: array subscript is above array bounds > > The patch also fixes a few other array bugs, which the compiler was > unable to find. Coding style violations are also fixed. Which makes it very hard to see what you are actually changing and whether it is a bug. It certainly looks like one but the changes muddled in with a random subset of format fixes (even in the area patched only some style is fixed) looks pretty clunky - surely a for() loop would be far cleaner. But yes agreed - its a bug, it wants fixing and style can be sorted later. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists