linux-kernel - Re: parport_pc: Fix subscription bugs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200906011127.03296.mb@bu3sch.de>
Date:	Mon, 1 Jun 2009 11:27:03 +0200
From:	Michael Buesch <mb@...sch.de>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: parport_pc: Fix subscription bugs

On Monday 01 June 2009 11:14:40 Alan Cox wrote:
> On Mon, 1 Jun 2009 11:00:33 +0200
> Michael Buesch <mb@...sch.de> wrote:
> 
> > This patch fixes array subscription bugs in the parport_pc driver.
> > 
> > drivers/parport/parport_pc.c: In function ‘parport_irq_probe’:
> > drivers/parport/parport_pc.c:1589: warning: array subscript is above array bounds
> > drivers/parport/parport_pc.c: In function ‘parport_pc_probe_port’:
> > drivers/parport/parport_pc.c:1579: warning: array subscript is above array bounds
> > 
> > The patch also fixes a few other array bugs, which the compiler was
> > unable to find. Coding style violations are also fixed.
> 
> Which makes it very hard to see what you are actually changing and
> whether it is a bug. It certainly looks like one but the changes muddled
> in with a random subset of format fixes (even in the area patched only
> some style is fixed)

Yeah well. If I did not fix the style violations, somebody else would have complained
already that when somebody touches some code he should also fix the style issues. ;)
Happened to be several times, so I chose to fix them here...

-- 
Greetings, Michael.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/