linux-kernel - Re: [PATCH] kgdbts: unify/generalize gdb breakpoint adjustment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bd0f97a0906041755q7588ba76l1e4e1eb8bdbe336@mail.gmail.com>
Date:	Thu, 4 Jun 2009 20:55:40 -0400
From:	Mike Frysinger <vapier.adi@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>
Cc:	jason.wessel@...driver.com, kgdb-bugreport@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kgdbts: unify/generalize gdb breakpoint adjustment

On Thu, Jun 4, 2009 at 20:50, Andrew Morton wrote:
> On Tue,  2 Jun 2009 03:17:30 -0400
> Mike Frysinger <vapier@...too.org> wrote:
>
>> +     instruction_pointer(&kgdbts_regs) += offset;
>
> instruction_pointer() cannot be used as an lvalue, thankfully.
>
> x86_64:
>
> drivers/misc/kgdbts.c: In function 'check_and_rewind_pc':
> drivers/misc/kgdbts.c:306: error: invalid lvalue in assignment

should be easy to fix:
--- a/arch/x86/include/asm/ptrace.h
+++ b/arch/x86/include/asm/ptrace.h
@@ -236,10 +236,7 @@
 #endif
 }

-static inline unsigned long instruction_pointer(struct pt_regs *regs)
-{
-   return regs->ip;
-}
+#define instruction_pointer(regs) ((regs)->ip)

 static inline unsigned long frame_pointer(struct pt_regs *regs)
 {
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/