linux-kernel - Re: [PATCH 2/6] headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200906051026.34046.arnd@arndb.de>
Date:	Fri, 5 Jun 2009 10:26:33 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Jaswinder Singh Rajput <jaswinder@...nel.org>
Cc:	Sam Ravnborg <sam@...nborg.org>, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Tony Luck <tony.luck@...el.com>, linux-ia64@...r.kernel.org
Subject: Re: [PATCH 2/6] headers_check fix: ia64, fpswa.h

On Thursday 04 June 2009, Jaswinder Singh Rajput wrote:

> index 62edfce..797b064 100644
> --- a/arch/ia64/include/asm/fpswa.h
> +++ b/arch/ia64/include/asm/fpswa.h
> @@ -68,6 +68,7 @@ typedef struct {
>  	efi_fpswa_t	 fpswa;
>  } fpswa_interface_t;
>  
> +#ifdef __KERNEL__
>  extern fpswa_interface_t *fpswa_interface;
> -
> +#endif
>  #endif /* _ASM_IA64_FPSWA_H */

It's pretty obvious that the above data structure also doesn't
apply in user space. In fact it looks like the whole file should
just not be exported. Your patch is not helpful there because
it just silences the warning.

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/