linux-kernel - Re: [PATCH 0/6] headers_check fix patches 20090604

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1244167215.2522.7.camel@ht.satnam>
Date:	Fri, 05 Jun 2009 07:30:15 +0530
From:	Jaswinder Singh Rajput <jaswinder@...nel.org>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Russell King <rmk+lkml@....linux.org.uk>,
	Catalin Marinas <catalin.marinas@....com>,
	Tony Luck <tony.luck@...el.com>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Greg Ungerer <gerg@...pgear.com>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Michael Abbott <michael@...neidae.co.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	David Howells <dhowells@...hat.com>
Subject: Re: [PATCH 0/6] headers_check fix patches 20090604

Hello Sam,

On Thu, 2009-06-04 at 22:12 +0200, Sam Ravnborg wrote:
> On Thu, Jun 04, 2009 at 05:53:52PM +0530, Jaswinder Singh Rajput wrote:
> > Please Review :
> > 
> > Jaswinder Singh Rajput (6):
> >       headers_check fix: arm, hwcap.h
> >       headers_check fix: ia64, fpswa.h
> >       headers_check fix: m68k, swab.h
> >       headers_check fix: mips, ioctl.h
> >       headers_check fix: mn10300, ptrace.h
> >       headers_check fix: mn10300, setup.h
> 
> Please let the subject explain what was fixed.
> The fact that you used headers_check to detect the
> issue in the first place is less relevant.
> 
> For mips the subject could have been:
> 
> mips: use userspace compatible definition of _IOC_TYPECHECK
> 

OK, BTW I pointed this in commit log.

> Did you concentrate solely on headers_check output
> or did you carefully inspect the files you touched for userspace issues?
> I stroingly recommend to fix all userspace issues in files touched
> if this is possible.
> 

I did my best and fix all userspace issues in above files. Now I am
waiting for the review from maintainers.

Thanks,
--
JSR

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/