linux-kernel - Re: [PATCH v3] add MAX17040 Fuel Gauge driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <4A2C7911.80407@samsung.com>
Date:	Mon, 08 Jun 2009 11:36:01 +0900
From:	Minkyu Kang <mk7.kang@...sung.com>
To:	Trilok Soni <soni.trilok@...il.com>
Cc:	linux-kernel@...r.kernel.org, linux-pm@...ts.linux-foundation.org,
	linux-i2c@...r.kernel.org, Anton Vorontsov <cbou@...l.ru>,
	Andrew Morton <akpm@...ux-foundation.org>,
	kyungmin.park@...sung.com
Subject: Re: [PATCH v3] add MAX17040 Fuel Gauge driver

Dear Trilok Soni,

Thanks for review

> Hi Minkyu Kang,
> 
> On Fri, Jun 5, 2009 at 12:03 PM, Minkyu Kang<mk7.kang@...sung.com> wrote:
>> The MAX17040 is a I2C interfaced Fuel Gauge systems for lithium-ion batteries
>> This patch adds support the MAX17040 Fuel Gauge
>>
> 
> Thanks for making change. Some more comments.
> 
>>  endif # POWER_SUPPLY
>> diff --git a/drivers/power/Makefile b/drivers/power/Makefile
>> index 2fcf41d..9c48995 100644
>> --- a/drivers/power/Makefile
>> +++ b/drivers/power/Makefile
>> @@ -25,4 +25,5 @@ obj-$(CONFIG_BATTERY_TOSA)    += tosa_battery.o
>>  obj-$(CONFIG_BATTERY_WM97XX)   += wm97xx_battery.o
>>  obj-$(CONFIG_BATTERY_BQ27x00)  += bq27x00_battery.o
>>  obj-$(CONFIG_BATTERY_DA9030)   += da9030_battery.o
>> -obj-$(CONFIG_CHARGER_PCF50633) += pcf50633-charger.o
>> \ No newline at end of file
>> +obj-$(CONFIG_BATTERY_MAX17040))        += max17040_battery.o
> 
> Are we following any alphabetical order in this Makefile?
> 

I'm not sure either. :(
I just grouping with batteries.

>> +static int max17040_suspend(struct i2c_client *client,
>> +               pm_message_t state)
>> +{
>> +       struct max17040_chip *chip = i2c_get_clientdata(client);
>> +
>> +       cancel_delayed_work(&chip->work);
>> +       return 0;
>> +}
>> +
>> +static int max17040_resume(struct i2c_client *client)
>> +{
>> +       struct max17040_chip *chip = i2c_get_clientdata(client);
>> +
>> +       schedule_delayed_work(&chip->work, MAX17040_DELAY);
>> +       return 0;
>> +}
>> +
> 
> Please add #ifdef CONFIG_PM around suspend resume functions.
> 

Ok, I will.
Thanks

---
from, prom.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/