linux-kernel - Re: [PATCH 23/24] GFS2: Fix locking issue mounting gfs2meta fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090610095319.GC25527@infradead.org>
Date:	Wed, 10 Jun 2009 05:53:19 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Steven Whitehouse <swhiteho@...hat.com>
Cc:	linux-kernel@...r.kernel.org, cluster-devel@...hat.com,
	Christoph Hellwig <hch@...radead.org>
Subject: Re: [PATCH 23/24] GFS2: Fix locking issue mounting gfs2meta fs

On Wed, Jun 10, 2009 at 09:31:04AM +0100, Steven Whitehouse wrote:
>  static struct super_block *get_gfs2_sb(const char *dev_name)
>  {
> -	struct super_block *sb;

Any reason you don't merge get_gfs2_sb into gfs2_get_sb_meta?  That's
how most other get_sb callbacks are structured, and would also get rid
of the rather confusing get_gfs2_sb name.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/