linux-kernel - Re: [PATCH 10/24] GFS2: Don't warn when delete inode fails on ro filesystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1244628197.3355.7.camel@localhost.localdomain>
Date:	Wed, 10 Jun 2009 11:03:17 +0100
From:	Steven Whitehouse <swhiteho@...hat.com>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	linux-kernel@...r.kernel.org, cluster-devel@...hat.com
Subject: Re: [PATCH 10/24] GFS2: Don't warn when delete inode fails on ro
 filesystem

Hi,

On Wed, 2009-06-10 at 05:49 -0400, Christoph Hellwig wrote:
> On Wed, Jun 10, 2009 at 09:30:51AM +0100, Steven Whitehouse wrote:
> > If the filesystem is read-only, then we expect that delete inode
> > will fail, so there is no need to warn about it.
> 
> Umm, ->delete_inode should never be called on a read-only filesystem
> by the VFS.
> 

On a single node, thats true. With multiple nodes, some mounted ro and
some mounted rw, sometimes the ro node gets the baton passed to it, if
it happens to have a process holding open an inode thats been unlinked
on the rw node. In that case it has to ignore it and one of the rw nodes
will deal with the deallocation later,

Steve.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/