linux-kernel - Re: [PATCH 2/2] ftrace: document basic ftracer/ftracer graph needs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Jun 2009 14:45:01 -0400 (EDT)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Mike Frysinger <vapier.adi@...il.com>
cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ftrace: document basic ftracer/ftracer graph needs

On Wed, 10 Jun 2009, Mike Frysinger wrote:

> On Wed, Jun 10, 2009 at 13:04, Steven Rostedt wrote:
> > On Wed, 10 Jun 2009, Mike Frysinger wrote:
> >> While implementing ftracer and ftracer graph support, I found the exact
> >> arch implementation details to be a bit lacking (and my x86 foo ain't
> >> great).  So after pounding out support for the Blackfin arch, document
> >> the requirements.
> >
> > This does not belong in the Kconfig. That's the last place a developer
> > will look for implementing something.
> 
> yes and no -- i was following the existing documenting practice of
> ftrace where details were added to the Kconfig.  guess i should fix
> that in the process.

Documenting what should be selected and why is one thing, but to document 
implementation is another. I'm not against documentation in Kconfig, but 
that should explain more about why things are selected. But not 
implementation details.

> 
> there should be at least tips in each HAVE_XXX as to where to look for
> implementation details.

That can be opening a can of worms.

Really, the focus of the documentation in Kconfig is about why things must 
be selected, not how to implement the code to add that selection.

If there's a HAVE_XXX in Kconfig that I want to see how to implement it, I 
go off and do 'grep -r XXX Documentation'.

-- Steve