linux-kernel - Re: add bcm47xx watchdog driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A2FFFDA.6010807@free.fr>
Date:	Wed, 10 Jun 2009 20:47:54 +0200
From:	matthieu castet <castet.matthieu@...e.fr>
To:	Wim Van Sebroeck <wim@...ana.be>
CC:	Florian Fainelli <florian@...nwrt.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-mips@...ux-mips.org,
	biblbroks@...ampro.rs
Subject: Re: add bcm47xx watchdog driver

Hi,

Wim Van Sebroeck wrote:
> Hi Matthieu, Florian,
> 
>> It works very well on my Netgear WGT634U, thanks !
>>
>> Tested-by: Florian Fainelli <florian@...nwrt.org>
> 
> I incorporated the changes of Andrew and did a clean-up here and there to keep checkpatch happy.
> Could you test the attached diff to see that it still works.
> 
> Thanks,
> Wim.
> 

> +
> +#define WDT_DEFAULT_TIME	30	/* seconds */
> +#define WDT_MAX_TIME		255	/* seconds */
Why have changed this from 256 to 255 ?

> +}
> +
> +static int bcm47xx_wdt_notify_sys(struct notifier_block *this,
> +	nsigned long code, void *unused)
        ^^^^
Does this build ?


Matthieu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/