linux-kernel - Re: add bcm47xx watchdog driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090610190602.GL16090@infomag.iguana.be>
Date:	Wed, 10 Jun 2009 21:06:02 +0200
From:	Wim Van Sebroeck <wim@...ana.be>
To:	matthieu castet <castet.matthieu@...e.fr>
Cc:	Florian Fainelli <florian@...nwrt.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-mips@...ux-mips.org,
	biblbroks@...ampro.rs
Subject: Re: add bcm47xx watchdog driver

Hi Matthieu,

>> +
>> +#define WDT_DEFAULT_TIME	30	/* seconds */
>> +#define WDT_MAX_TIME		255	/* seconds */
> Why have changed this from 256 to 255 ?

Since you use a timer to control the real watchdog, the wdt_time function is arbitraty anyway.
Most watchdog drivers use 0xFFFF. Since you only went to 256 it made more sense to have it as 0xFF which is 255.
We can make it 65535 also. 

>> +}
>> +
>> +static int bcm47xx_wdt_notify_sys(struct notifier_block *this,
>> +	nsigned long code, void *unused)
>        ^^^^
> Does this build ?

Nope. should be unsigned.

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/