linux-kernel - Re: [PATCH v2] slab,slub: ignore __GFP_WAIT if we're booting or suspending

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.01.0906120809560.3237@localhost.localdomain>
Date:	Fri, 12 Jun 2009 08:16:41 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Pekka J Enberg <penberg@...helsinki.fi>
cc:	Nick Piggin <npiggin@...e.de>, Ingo Molnar <mingo@...e.hu>,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	benh@...nel.crashing.org, akpm@...ux-foundation.org,
	cl@...ux-foundation.org
Subject: Re: [PATCH v2] slab,slub: ignore __GFP_WAIT if we're booting or
 suspending



On Fri, 12 Jun 2009, Pekka J Enberg wrote:
> 
> Hmm. This is turning into one epic patch discussion for sure! But here's a 
> patch to do what you suggested. With the amount of patches I am 
> generating, I'm bound to hit the right one sooner or later, no?-)

Ok, this one looks pretty good. I like the statics, and I like how it lets 
each allocator decide what to do.

Small nit: your mm/slab.c patch does an obviously unnecessary mask in:

	cache_alloc_debugcheck_before(cachep, flags & slab_gfp_flags);

but that's stupid, because the bits were already masked earlier.

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/