[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090613070411.GA6682@elte.hu>
Date: Sat, 13 Jun 2009 09:04:11 +0200
From: Ingo Molnar <mingo@...e.hu>
To: Paul Mackerras <paulus@...ba.org>
Cc: Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
LKML <linux-kernel@...r.kernel.org>,
Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: perf_counters: page fault trace record
* Paul Mackerras <paulus@...ba.org> wrote:
> Corey Ashford writes:
>
> > One of the tools we are working on needs to be able to look not only at counts
> > of page faults, but where they are occurring (ip and faulting page address).
> >
> > What would you think about adding a new bit to the config record, something like:
>
> Can't you do what you need just using a page fault software
> counter with sample_type = PERF_SAMPLE_IP | PERF_SAMPLE_ADDR and
> sample_period = 1?
Yes, we should use a generic 'data address' field. A whole lot of
interesting events can live with that - only full-blown generic
tracepoints have more complex sample record formats.
Also, if this feature is added to pagefaults, please also add
support for it into tools/perf/, so that it gets tested/used.
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists