linux-kernel - Re: [PATCH 19/27] score: create kernel files asm-offsets.c entry.S head.S

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <OFC173E4DC.A0C85216-ON482575D4.00260559-482575D4.0026BA67@sunplusct.com>
Date:	Sat, 13 Jun 2009 14:58:33 +0800
From:	liqin.chen@...plusct.com
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Arnd Bergmann <arnd@...db.de>, linux-arch@...r.kernel.org,
	linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org
Subject: Re: [PATCH 19/27] score: create kernel files asm-offsets.c entry.S head.S

Sam Ravnborg <sam@...nborg.org> 写于 2009-06-10 03:18:26:

> > new file mode 100644
> > index 0000000..a7432c1
> > --- /dev/null
> > +++ b/arch/score/kernel/head.S
> > @@ -0,0 +1,70 @@
> > +#include <asm/asm-offsets.h>
> > +
> > +       .extern start_kernel
> > +       .global init_thread_union
> > +       .global kernelsp
> > +
> > +       .section .init.text, "ax"
> 
> Please use section definitions from include/linux/init.h.
> __INIT in this case.
> 
> Other architectures uses __HEAD so they have full control
> on where to add this code in the final image.
> 

Thanks Sam, I used macro define in linux/init.h instead of 
the code in all .S files.

Best Regards
Liqin
--