linux-kernel - Re: [PATCH 2/2] use the TASK_COMM_LEN macro instead of sizeof(tsk->comm)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090615001410.24327266@lxorguk.ukuu.org.uk>
Date:	Mon, 15 Jun 2009 00:14:10 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Evgeni Golov <sargentd@...-welt.net>
Cc:	linux-kernel@...r.kernel.org, Evgeni Golov <sargentd@...-welt.net>
Subject: Re: [PATCH 2/2] use the TASK_COMM_LEN macro instead of
 sizeof(tsk->comm)

On Sun, 14 Jun 2009 18:57:48 +0200
Evgeni Golov <sargentd@...-welt.net> wrote:

> sizeof(tsk->comm) == TASK_COMM_LEN, always, so why not use it?

Because if the size ever changes the existing code will remain correct
and your changes will become a dangerous buffer overrun ?

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/