linux-kernel - Re: [PATCH 2/2] use the TASK_COMM_LEN macro instead of sizeof(tsk->comm)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090615055608.GH18660@dragonheart.kerker.die-welt.net>
Date:	Mon, 15 Jun 2009 07:56:08 +0200
From:	Evgeni Golov <evgeni@...ian.org>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] use the TASK_COMM_LEN macro instead of
	sizeof(tsk->comm)

On Mon, Jun 15, 2009 at 12:14:10AM +0100, Alan Cox wrote:
> On Sun, 14 Jun 2009 18:57:48 +0200
> Evgeni Golov <sargentd@...-welt.net> wrote:
> 
> > sizeof(tsk->comm) == TASK_COMM_LEN, always, so why not use it?
> 
> Because if the size ever changes the existing code will remain correct
> and your changes will become a dangerous buffer overrun ?

But shouldn't TASK_COMM_LEN change then too?
Just wondering, in the end it's a cosmetic cange, but looking at the 
code, we rely on TASK_COMM_LEN in other places often enough to break 
something when a task->comm is not TASK_COMM_LEM big.

Regards
Evgeni
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/