linux-kernel - Re: [PATCH] mfd/da903x: initialize PMIC core early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A3655DC.9090407@compulab.co.il>
Date:	Mon, 15 Jun 2009 17:08:28 +0300
From:	Mike Rapoport <mike@...pulab.co.il>
To:	Samuel Ortiz <sameo@...ux.intel.com>
CC:	eric miao <eric.y.miao@...il.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mfd/da903x: initialize PMIC core early



Samuel Ortiz wrote:
> Hi Mike,
> 
> On Mon, Jun 15, 2009 at 03:02:09PM +0300, Mike Rapoport wrote:
>> Samuel,
>> It'd be great if this can go to 2.6.31
> Sure. Care to explain why this needs to be called earlier ?

We want to have da903x regulators available early during boot, and since they
are subdevices of mfd/da903x they cannot be enabled until the da903x core is
initialized.
I just saw Liam Girdwood pull request with "regulator: Move regulator drivers to
subsys_initcall()" commit and jumped in :)


> Cheers,
> Samuel.
> 
>> Signed-off-by: Mike Rapoport <mike@...pulab.co.il>
>> ---
>>  drivers/mfd/da903x.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/mfd/da903x.c b/drivers/mfd/da903x.c
>> index 7283d88..e5ffe56 100644
>> --- a/drivers/mfd/da903x.c
>> +++ b/drivers/mfd/da903x.c
>> @@ -561,7 +561,7 @@ static int __init da903x_init(void)
>>  {
>>  	return i2c_add_driver(&da903x_driver);
>>  }
>> -module_init(da903x_init);
>> +subsys_initcall(da903x_init);
>>
>>  static void __exit da903x_exit(void)
>>  {
>> -- 
>> 1.6.0.6
>>
>>
>> -- 
>> Sincerely yours,
>> Mike.
>>
> 

-- 
Sincerely yours,
Mike.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/