linux-kernel - Re: [GIT PULL] voltage regulator updates for 2.6.31-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.01.0906150927390.3305@localhost.localdomain>
Date:	Mon, 15 Jun 2009 09:29:54 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Liam Girdwood <lrg@...mlogic.co.uk>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] voltage regulator updates for 2.6.31-rc1

On Mon, 15 Jun 2009, Liam Girdwood wrote:
>
>  drivers/regulator/lp3971.c                   |  562 ++++++++++++++++++++++++++
>  include/linux/regulator/lp3971.h             |   51 +++

So I really don't like this.

Why the heck would "lp3971.h" be under "include/linux"? That makes no 
sense what-so-ever. 

Why isn't it just

	drivers/regulator/lp3971.c
	drivers/regulator/lp3971.h

instead? There is never any reason for anything but the lp3971 driver to 
include its own header file, they should _not_ be split up to be in two 
different places.

In fact, why do we have a "include/linux/regulator/" at all? Does anybody 
else ever care? I doubt it.

Anyway, I pulled it, but I think this needs to be fixed. 

		Linus

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/