linux-kernel - Re: [PATCH v3] filter local function prefixed by $L

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.0906151214160.30161@gandalf.stny.rr.com>
Date:	Mon, 15 Jun 2009 12:30:40 -0400 (EDT)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	David Daney <ddaney@...iumnetworks.com>
cc:	Wu Zhangjin <wuzhangjin@...il.com>, linux-mips@...ux-mips.org,
	linux-kernel@...r.kernel.org,
	Wang Liming <liming.wang@...driver.com>,
	Wu Zhangjin <wuzj@...ote.com>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Nicholas Mc Guire <der.herr@...r.at>,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH v3] filter local function prefixed by $L


On Mon, 15 Jun 2009, David Daney wrote:

> Wu Zhangjin wrote:
> > From: Wu Zhangjin <wuzj@...ote.com>
> > 
> > this patch fixed the warning as following:
> > 
> > mipsel-linux-gnu-objcopy: 'fs/proc/.tmp_gl_devices.o': No such file
> > mipsel-linux-gnu-ld: fs/proc/.tmp_gl_devices.o: No such file: No such
> > file or directory
> > rm: cannot remove `fs/proc/.tmp_gl_devices.o': No such file or directory
> > rm: cannot remove `fs/proc/.tmp_mx_devices.o': No such file or directory
> > 
> > the real reason of above warning is that the $Lxx local functions will
> > be treated as global symbols, so, should be filtered.
> > 
> > Signed-off-by: Wu Zhangjin <wuzj@...ote.com>
> > ---
> >  scripts/recordmcount.pl |    4 ++++
> >  1 files changed, 4 insertions(+), 0 deletions(-)
> > 
> > diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl
> > index 533d3bf..542cb04 100755
> > --- a/scripts/recordmcount.pl
> > +++ b/scripts/recordmcount.pl
> > @@ -343,6 +343,10 @@ sub update_funcs
> >  	if (!$use_locals) {
> >  	    return;
> >  	}
> > +	# filter $LXXX tags
> > +	if ("$ref_func" =~ m/\$L/) {
> > +		return;
> > +	}
> 
> Certainly this is true for mips.  I doubt it is for all architectures targed
> by Linux.

Yes, that should probably go into a mips only change. Unless you can 
reproduce it on all other archs, or at least x86.

You could also do this in the function_regex variable.

 "^([0-9a-fA-F]+)\\s+<(.|[^\$]L.*?|\$[^L].*?|[^\$][^L].*?)>:"

There may even be a better way, but I'm not in the mood to look it up ;-)

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/