linux-kernel - [PATCH] driver core: remove unheeded warning about driver methods

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.0906171158190.2820-100000@iolanthe.rowland.org>
Date:	Wed, 17 Jun 2009 11:59:51 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Greg KH <greg@...ah.com>
cc:	SCSI development list <linux-scsi@...r.kernel.org>,
	Kernel development list <linux-kernel@...r.kernel.org>
Subject: [PATCH] driver core: remove unheeded warning about driver methods

This patch (as1263) removes a warning which has been present for so
long, and consistently ignored, that it obviously is not doing any
good.  It gets triggered on pretty much every boot by the SCSI disk
and cdrom drivers.  Evidently nobody cares.

Signed-off-by: Alan Stern <stern@...land.harvard.edu>

---

Index: usb-2.6/drivers/base/driver.c
===================================================================
--- usb-2.6.orig/drivers/base/driver.c
+++ usb-2.6/drivers/base/driver.c
@@ -225,12 +225,6 @@ int driver_register(struct device_driver
 
 	BUG_ON(!drv->bus->p);
 
-	if ((drv->bus->probe && drv->probe) ||
-	    (drv->bus->remove && drv->remove) ||
-	    (drv->bus->shutdown && drv->shutdown))
-		printk(KERN_WARNING "Driver '%s' needs updating - please use "
-			"bus_type methods\n", drv->name);
-
 	other = driver_find(drv->name, drv->bus);
 	if (other) {
 		put_driver(other);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/