linux-kernel - Re: [PATCH] driver core: remove unheeded warning about driver methods

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A391909.2090609@panasas.com>
Date:	Wed, 17 Jun 2009 19:25:45 +0300
From:	Boaz Harrosh <bharrosh@...asas.com>
To:	Alan Stern <stern@...land.harvard.edu>,
	Hannes Reinecke <hare@...e.de>,
	James Bottomley <James.Bottomley@...senpartnership.com>
CC:	Greg KH <greg@...ah.com>,
	SCSI development list <linux-scsi@...r.kernel.org>,
	Kernel development list <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] driver core: remove unheeded warning about driver methods

On 06/17/2009 06:59 PM, Alan Stern wrote:
> This patch (as1263) removes a warning which has been present for so
> long, and consistently ignored, that it obviously is not doing any
> good.  It gets triggered on pretty much every boot by the SCSI disk
> and cdrom drivers.  Evidently nobody cares.
> 
> Signed-off-by: Alan Stern <stern@...land.harvard.edu>
> 
> ---
> 
> Index: usb-2.6/drivers/base/driver.c
> ===================================================================
> --- usb-2.6.orig/drivers/base/driver.c
> +++ usb-2.6/drivers/base/driver.c
> @@ -225,12 +225,6 @@ int driver_register(struct device_driver
>  
>  	BUG_ON(!drv->bus->p);
>  
> -	if ((drv->bus->probe && drv->probe) ||
> -	    (drv->bus->remove && drv->remove) ||
> -	    (drv->bus->shutdown && drv->shutdown))
> -		printk(KERN_WARNING "Driver '%s' needs updating - please use "
> -			"bus_type methods\n", drv->name);
> -
>  	other = driver_find(drv->name, drv->bus);
>  	if (other) {
>  		put_driver(other);
> 
> --


There was a proper and simple fix for that problem here:
http://www.spinics.net/lists/kernel/msg860289.html

Hannes please re push this patch properly. We want it ;)

Boaz

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/